Fix bug relating to type conversion in function calls #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
force-pushed
the
fix/bug-in-type-conversion-func-call
branch
from
7c94095 to
4c5bf19
Compare
nlewycky
reviewed
Sep 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
- Coverage 31.77% 31.76% -0.01%
==========================================
Files 185 185
Lines 27015 27017 +2
==========================================
- Hits 8583 8582 -1
- Misses 18432 18435 +3
Continue to review full report at Codecov.
|
syrusakbary
approved these changes
Sep 9, 2020
|
bors try |
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1596
I attempted to use constant expressions so we didn't have to duplicate the macro, but
std::mem::transmuteis a compile error if you attempt to transmute from A to B where size_of(A) != size_of(B), even if it's in a branch likeif falseedit: this pr no longer uses any unsafe code, perhaps we should review making those functions
constnowReview